Add the percent unit to the default units in Core #33468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Created this issue for potential follow-ups #33470 |
youknowriad
force-pushed
the
add/add-percent-to-default-units
branch
from
6960702
to
4c0c055
Compare
|
Tested and does restore Is the change also needed here https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/use-setting/index.js#L44? |
|
@hellofromtonya good catch, yeah I think it's better to be consistent. |
|
Size Change: +4 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
youknowriad
added a commit
that referenced
this pull request
Jul 15, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added a commit
that referenced
this pull request
Jul 15, 2021
gwwar
pushed a commit
that referenced
this pull request
Jul 19, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33463
This PR restores the
%unit in columns width but also enables it in all spacing customization tools. See discussion in #33463.I think the handling of units is still very incomplete, I'll be opening a separate issue to continue this discussion and explain some of the current flaws.